feat: create admin account on setup - #81
Merged
Merged
Conversation
robsimmons
reviewed
Aug 14, 2026
robsimmons
force-pushed
the
install-admin
branch
2 times, most recently
from
August 14, 2026 18:59
f42895b to
37ea165
Compare
robsimmons
force-pushed
the
install-admin
branch
from
August 14, 2026 19:03
37ea165 to
43251fd
Compare
robsimmons
force-pushed
the
install-admin
branch
2 times, most recently
from
August 14, 2026 19:29
bd60fd5 to
fdf53d4
Compare
We treat it as a proxy for 'has installed' in do_uninstall.
robsimmons
force-pushed
the
install-admin
branch
from
August 14, 2026 20:03
d91c68d to
be525a9
Compare
robsimmons
marked this pull request as ready for review
August 14, 2026 20:54
GitHub changed the name here recently.
robsimmons
force-pushed
the
install-admin
branch
from
August 16, 2026 22:02
3088dea to
ffbb5ba
Compare
robsimmons
reviewed
Aug 16, 2026
Comment on lines
+108
to
+111
| Run the installer on your Linux server: | ||
|
|
||
| ```bash | ||
| curl -sSf https://raw.githubusercontent.com/leanprover/lean-workbench/main/install.sh | bash | ||
| bash <(curl -sSf https://raw.githubusercontent.com/leanprover/lean-workbench/main/install.sh) |
Collaborator
There was a problem hiding this comment.
What's the reason for changing this? curl-pipe-to-bash is a tragic but common idiom
Member
Author
There was a problem hiding this comment.
It doesn't work - it closes stdin for the script which thus does not ask the questions it would normally ask. We could alternatively fix this by accessing /dev/tty directly in the script.
robsimmons
force-pushed
the
install-admin
branch
from
August 16, 2026 22:07
ffbb5ba to
8388d17
Compare
robsimmons
approved these changes
Aug 16, 2026
robsimmons
force-pushed
the
install-admin
branch
from
August 17, 2026 15:47
a891881 to
8388d17
Compare
robsimmons
force-pushed
the
install-admin
branch
from
August 17, 2026 15:47
8388d17 to
2e604ab
Compare
Vtec234
commented
Aug 17, 2026
| // ? [env.ORIGIN.replace('https:', 'http:'), env.ORIGIN.replace('http:', 'https:')] | ||
| // : [], | ||
| trustedOrigins: isDevMode() | ||
| ? /* allow anything in dev mode */ req => [req?.headers.get('origin')] |
Member
Author
There was a problem hiding this comment.
Remark for future: we may want to read Host here, Origin is not set on same-origin GET requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.sh.But make this configurable?Default to localhost for now until someone complains.Rob complained, this hit him trying to run workbench within a VM/setuppage with admin authentication./setuppage.Complain onThis requires some/setuplogin page ifwindow.location.URLis notbaseURL.baseURLadaptations, left for a follow-up PR.Allow admin login post-setupIn a follow-on PR.