Skip to content

refactor: replace Split in loops with more efficient SplitSeq #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldas merged 2 commits into from
May 11, 2026
+4 −4
Merged

refactor: replace Split in loops with more efficient SplitSeq #2969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
731d818
refactor: replace Split in loops with more efficient SplitSeq
box4wangjing May 10, 2026
f535bac
refactor: replace Split in loops with more efficient SplitSeq
box4wangjing May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions middleware/extractor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ func createExtractors(lookups string, limit uint) ([]ValuesExtractor, error) {
limit = extractorLimit
}

sources := strings.Split(lookups, ",")
sources := strings.SplitSeq(lookups, ",")
var extractors = make([]ValuesExtractor, 0)
for _, source := range sources {
for source := range sources {
parts := strings.Split(source, ":")
if len(parts) < 2 {
return nil, fmt.Errorf("extractor source for lookup could not be split into needed parts: %v", source)
Expand Down
4 changes: 2 additions & 2 deletions router_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,8 +2235,8 @@ func testRouterAPI(t *testing.T, api []testRoute) {
c.SetRequest(httptest.NewRequest(route.Method, route.Path, nil))
e.router.Route(c)

tokens := strings.Split(route.Path[1:], "/")
for _, token := range tokens {
tokens := strings.SplitSeq(route.Path[1:], "/")
for token := range tokens {
if token[0] == ':' {
assert.Equal(t, c.pathValues.GetOr(token[1:], "---none---"), token)
}
Expand Down
Loading