Skip to content

feat: add enforcement latency metric with operation labels - #450

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:enforcement-latency-seconds
Sep 19, 2026
Merged

feat: add enforcement latency metric with operation labels#450
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:enforcement-latency-seconds

Conversation

@rawadhossain

@rawadhossain rawadhossain commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Adds node_readiness_enforcement_latency_seconds with add/remove operation labels, keeping node_readiness_reconciliation_latency_seconds unchanged.
  • Updates scale PromQL queries and the scalability report.
  • Updates monitoring.md and docs/TEST_README.md.
  • Adds related tests.

from the design doc:

image image

Related to #446

Type of Change

/kind feature

Testing

make test, make lint, go vet, gofmt -l all pass.

Checklist

  • make test passes
  • make lint passes

@kubernetes-prow kubernetes-prow Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2026
@netlify

netlify Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit 59277fc
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6aaed87054313500087d6fd4
😎 Deploy Preview https://deploy-preview-450--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mrunalp and tallclair August 24, 2026 10:17
@kubernetes-prow

kubernetes-prow Bot commented Aug 24, 2026

Copy link
Copy Markdown

Hi @rawadhossain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2026
@rawadhossain rawadhossain mentioned this pull request Aug 24, 2026
Open
6 of 7 tasks
@rawadhossain

rawadhossain commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

/cc @ajaysundark

@kubernetes-prow
kubernetes-prow Bot requested a review from ajaysundark August 26, 2026 08:20
@rawadhossain

rawadhossain commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

/cc @AvineshTripathi

AvineshTripathi
AvineshTripathi reviewed Aug 29, 2026
View reviewed changes

@AvineshTripathi AvineshTripathi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

left some minor question

Comment thread internal/controller/nodereadinessrule_controller.go
Comment thread internal/metrics/metrics_test.go Outdated
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2026
@AvineshTripathi

AvineshTripathi commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2026
@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from 9b1a813 to 68de79c Compare August 29, 2026 14:09
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2026
@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from 68de79c to bd881be Compare August 29, 2026 14:10
@rawadhossain

rawadhossain commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

@AvineshTripathi i dont know why the CI check is failing in every PR. From my end everything looks fine.

@AvineshTripathi

AvineshTripathi commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

It's seems slack invite redirection is down. I have raised this in their channel. Will ping you there

AvineshTripathi
AvineshTripathi reviewed Aug 30, 2026
View reviewed changes

@AvineshTripathi AvineshTripathi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

left a minor suggestion
Tested the metrics part locally. However, didn't run the scale test though

Comment thread internal/controller/nodereadinessrule_controller.go Outdated
@kubernetes-prow kubernetes-prow Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2026
@AvineshTripathi

AvineshTripathi commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@rawadhossain please resolve the conflicts too. Thanks!

@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from bd881be to 3ce515a Compare August 30, 2026 16:13
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2026
@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from 3ce515a to b07d00d Compare August 30, 2026 16:32
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2026
@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from b07d00d to d959fad Compare September 1, 2026 08:32
@rawadhossain

rawadhossain commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

@AvineshTripathi resolved the conflicts and inconsistency.
Also applied the same test refactor here as in #447 (review). lmk if this looks good. Thanks.

AvineshTripathi
AvineshTripathi reviewed Sep 5, 2026
View reviewed changes

@AvineshTripathi AvineshTripathi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

wouldn't we get conflicts when one of the PR gets merged regarding the util func

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2026
@rawadhossain

rawadhossain commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Yes probably we would. Will have to resolve the conflict afterwards.

@ajaysundark

ajaysundark commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

/hold

@rawadhossain pls feel free to unhold after rebasing for conflicts

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2026
@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2026
@rawadhossain
enforcement latency metric
59277fc 
Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
@rawadhossain
rawadhossain force-pushed the enforcement-latency-seconds branch from d959fad to 59277fc Compare September 19, 2026 18:46
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2026
@rawadhossain

rawadhossain commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

/lgtm
/unhold

@kubernetes-prow

kubernetes-prow Bot commented Sep 19, 2026

Copy link
Copy Markdown

@rawadhossain: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2026
@rawadhossain

rawadhossain commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

cc @ajaysundark for LGTM.

@ajaysundark

ajaysundark commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2026
@kubernetes-prow

kubernetes-prow Bot commented Sep 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, rawadhossain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit 08a260f into kubernetes-sigs:main Sep 19, 2026
11 checks passed
@rawadhossain rawadhossain mentioned this pull request Sep 25, 2026
Open
@arnab-logs arnab-logs mentioned this pull request Sep 30, 2026
Open
arnab-logs pushed a commit to arnab-logs/node-readiness-controller that referenced this pull request Oct 1, 2026
@rawadhossain @arnab-logs
feat: add enforcement latency metric with operation labels (kubernete…
84904f5 
…s-sigs#450)

Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp
@tallclair tallclair Awaiting requested review from tallclair
@ajaysundark ajaysundark Awaiting requested review from ajaysundark
1 more reviewer
@AvineshTripathi AvineshTripathi AvineshTripathi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ajaysundark ajaysundark

@AvineshTripathi AvineshTripathi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rawadhossain @AvineshTripathi @ajaysundark