Skip to content

fix: correct ordering on revisions selector on hardware page #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanpeixinho merged 1 commit into from
Jun 24, 2026
+15 −0
Merged

fix: correct ordering on revisions selector on hardware page #1937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions backend/kernelCI_app/views/hardwareSelectorsView.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ def _sanitize_records(self, selectors_raw: list[dict]) -> HardwareSelectorsRespo
}
)

for tree in trees:

@alanpeixinho alanpeixinho Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: because the difference might be negligible, but with this, we might want to remove the order by on the database query

@gustavobtflores gustavobtflores Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering in the query is different from what we want (newest-first) and is needed for the DISTINCT ON, we could move all the ordering to the query, but it would increase complexity a little

tree["branches"].sort(
key=lambda branch: (
branch["git_repository_url"],
branch["git_repository_branch"],
)
)
for branch in tree["branches"]:
branch["revisions"].sort(
key=lambda revision: revision["start_time"],
reverse=True,
)

trees.sort(key=lambda tree: tree["tree_name"])

sanitized_trees: list[HardwareSelectorTree] = []
for tree in trees:
branches = [
Expand Down
Loading