fix process output capture and timeouts

server/README.md

@@ -74,6 +74,7 @@ export OUTPUT_DIR=/tmp/recordings
 
 - **YAML Spec**: `GET /spec.yaml`
 - **JSON Spec**: `GET /spec.json`
+- **Process execution guide**: [`docs/processes.md`](docs/processes.md)
 - **Browser REPL guide**: [`docs/repl.md`](docs/repl.md)
 
 ## 🔧 Development

server/cmd/api/api/api.go

@@ -74,8 +74,9 @@ type ApiService struct {
 	watches map[string]*fsWatch
 
 	// Process management
-	procMu sync.RWMutex
-	procs  map[string]*processHandle
+	procMu        sync.RWMutex
+	procs         map[string]*processHandle
+	processOutput *processOutputBudget
 
 	// Neko authenticated client
 	nekoAuthClient *nekoclient.AuthClient
@@ -195,6 +196,7 @@ func New(
 	s2Storage S2Storage,
 	egressPolicy *egresspolicy.State,
 	webauthnHook *webauthnhook.Hook,
+	processOutputConfig ProcessOutputConfig,
 ) (*ApiService, error) {
 	switch {
 	case recordManager == nil:
@@ -215,6 +217,10 @@ func New(
 		return nil, fmt.Errorf("webauthnHook cannot be nil")
 	}
 
+	outputBudget, err := newProcessOutputBudget(processOutputConfig)
+	if err != nil {
+		return nil, err
+	}
 	screenshotEnabled := func() bool { return telemetrySession.CategoryEnabled(events.Screenshot) }
 	mon := cdpmonitor.New(upstreamMgr, telemetrySession.Publish, displayNum, slog.Default(), screenshotEnabled)
 	_ = mon.SetTelemetry(false)
@@ -226,6 +232,7 @@ func New(
 		defaultRecorderID: "default",
 		watches:           make(map[string]*fsWatch),
 		procs:             make(map[string]*processHandle),
+		processOutput:     outputBudget,
 		upstreamMgr:       upstreamMgr,
 		stz:               stz,
 		nekoAuthClient:    nekoAuthClient,

server/cmd/api/api/api_test.go

@@ -433,7 +433,7 @@ func testWebAuthnWithMetro(t *testing.T, metroURL string) *webauthnhook.Hook {
 func newSvc(t *testing.T, mgr recorder.RecordManager) (*ApiService, error) {
 	t.Helper()
 	ts, es := newTelemetrySession(t)
-	return New(mgr, newMockFactory(), newTestUpstreamManager(), scaletozero.NewNoopController(), newMockNekoClient(t), ts, es, 0, nil, nil, testEgressPolicy(t), testWebAuthn(t))
+	return New(mgr, newMockFactory(), newTestUpstreamManager(), scaletozero.NewNoopController(), newMockNekoClient(t), ts, es, 0, nil, nil, testEgressPolicy(t), testWebAuthn(t), ProcessOutputConfig{})
 }
 
 func TestApiService_PatchChromiumFlags(t *testing.T) {

server/cmd/api/api/display_test.go

@@ -39,7 +39,7 @@ func testFFmpegFactory(t *testing.T, tempDir string) recorder.FFmpegRecorderFact
 func newTestServiceWithFactory(t *testing.T, mgr recorder.RecordManager, factory recorder.FFmpegRecorderFactory) *ApiService {
 	t.Helper()
 	ts, es := newTelemetrySession(t)
-	svc, err := New(mgr, factory, newTestUpstreamManager(), scaletozero.NewNoopController(), newMockNekoClient(t), ts, es, 0, nil, nil, testEgressPolicy(t), testWebAuthn(t))
+	svc, err := New(mgr, factory, newTestUpstreamManager(), scaletozero.NewNoopController(), newMockNekoClient(t), ts, es, 0, nil, nil, testEgressPolicy(t), testWebAuthn(t), ProcessOutputConfig{})
 	require.NoError(t, err)
 	return svc
 }