Skip to content

Change filename in create to ASCII only#132

Open
blakeembrey wants to merge 1 commit intomasterfrom
be/ascii-download-filename
Open

Change filename in create to ASCII only#132
blakeembrey wants to merge 1 commit intomasterfrom
be/ascii-download-filename

Conversation

@blakeembrey
Copy link
Copy Markdown
Member

This should resolve the issue with #27. It's the recommendation in the RFC to use ASCII only for filename: https://www.rfc-editor.org/rfc/rfc6266#appendix-D

@blakeembrey blakeembrey requested a review from Phillip9587 May 4, 2026 22:36
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2bb7da3) to head (25c2492).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          223       227    +4     
  Branches        81        82    +1     
=========================================
+ Hits           223       227    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Phillip9587 Phillip9587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants