Repository navigation
Feature - temporary urls - #168
Conversation
|
This is great! I'll try verifying it asap, and whether my custom path replacement normalizer can be removed when this PR ships. |
|
@rvanlaak Hello! 👋 Have you been able to test the feature? |
|
Not yet. Can verify it Tomorrow. |
5813a41 to
cf7eaf4
Compare
as without this, a custom normalizer will need to overwrite the values when handled by the serializer
Just like the OriginalStorage exposes storage. Without this change it does not seem possible to generate temporaryUrls for S3 buckets.
cf7eaf4 to
13650c5
Compare
|
Hi @rvanlaak, I rebased this PR on Variation existence is now cached once a file is known to be stored, so signing the URL of an existing variation no longer sends a Also:
Except if you have a negative feedback on this PR, I am going to merge it by the end of the week. |
|
Marked a block in my calendar for tomorrow afternoon. If I can't make it to provide feedback by eod I will also let you know. |
|
Hi @xavierlacot , I've checked out and tested locally, and can confirm that all works as expected. It will allow me to remove little pieces of my custom code, especially the part related to what you're mentioning about the A big part of it is related to my custom normalizers, but that code is unrelated to this PR and I'll try drafting another PR for this repo to get that part rolling too. |
|
Alright then, thanks for the feedback and your contributions :-) |
fix #75
Co-authored with @rvanlaak, supersedes #72 and #79
Add native temporary (pre-signed) URL generation for medias and their variations, so applications backed by an S3-compatible bucket can serve files directly instead of proxying them through PHP.
A new
getTemporaryUrl()method is available on Media, MediaVariation and both storages, signing the actual storage path with a configurable expiration.The bundle also stops forcing a public visibility when writing files, so the visibility configured on the Flysystem storage now applies, which is required for private buckets.