Prototype fix for emberjs#19287: defer dynamic attribute updates to commit - #36
Open
johanrd wants to merge 1 commit into
Open
Prototype fix for emberjs#19287: defer dynamic attribute updates to commit#36johanrd wants to merge 1 commit into
johanrd wants to merge 1 commit into
Conversation
Defer every dynamic attribute update at the opcode site through the env transaction and flush at the top of commit(), after the tracking transaction has closed -- mirroring how modifier install/update is already scheduled. No name-specific behavior added. Flips the GH#19287 repro from @todo to a passing @test. Full suite: 9436 tests, 0 failures. tsc clean.
johanrd
force-pushed
the
prototype-fix-gh19287-generic
branch
from
July 27, 2026 09:37
2895347 to
829a6f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for emberjs#19287 (see also the todo-test PR emberjs#21529).
Defers every dynamic attribute update at the opcode site through the env transaction, flushed at the top of
TransactionImpl.commit()— after the tracking transaction has closed, mirroring how modifier install/update is already scheduled. No name-specific behavior added (deliberately; see emberjs#21344 for why the attribute layer needs fewer per-name special cases, not more).Verification: full browser suite green (9436 tests, 0 failures),
tsc --noEmitclean, the GH#19287 repro passes as@test.