fix(stack-cli): clarify editor URL in dev server startup output#183
Open
avrahamr wants to merge 1 commit into
Open
fix(stack-cli): clarify editor URL in dev server startup output#183avrahamr wants to merge 1 commit into
avrahamr wants to merge 1 commit into
Conversation
The startup banner advertised 'Editor Server: http://localhost:<editorPort>', which reads like a browsable page. That port is a Socket.io/port-discovery backend whose only HTTP route is /editor-connect — every other path (including /) returns 'Not Found', so users who open it in a browser hit a 404. Point the line at the actual editor UI (/aiditor on the dev server) and keep the socket server URL as a clarifying sub-line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dev server startup banner prints:
This reads like a URL you open in a browser, but
:3301(the editor port) is a Socket.io / port-discovery backend. Its only HTTP route is/editor-connect; every other path — including/, which is what a browser requests — returnsNot Found. So users naturally open the advertised link and hit a 404, thinking the editor is broken.Change
packages/jay-stack/stack-cli/lib/server.ts: relabel the line to point at the actual editor UI (/aiditoron the dev server port) and demote the socket server URL to a clarifying sub-line.packages/jay-stack/stack-cli/README.md: update the sample startup output to match.New output:
The
📱 Dev Server:line is intentionally left unchanged, since the smoke tests parse it to detect the server URL.Open questions for maintainers
/aiditorassumption. The/aiditorroute is contributed by theaiditorplugin, not the CLI core. If a project runs the dev server without that plugin, the printed link won't resolve. Happy to gate the AIditor line on the plugin being present, or to reword so it only clarifies the socket server without asserting/aiditor— whichever you prefer.design-log/83 - dev server logging and timing.mdsample output untouched, treating design-log entries as dated records rather than living docs. Let me know if you'd rather I update those too.Validation
Built and tested locally against
@jay-framework/jay-stack-cli:yarn install(workspace) — ✅wsrun -p @jay-framework/jay-stack-cli -r -t build— ✅ (edit confirmed present in compileddist/index.js)build:check-types(tsc) — ✅ no type errorstest(vitest) — ✅ 108/108 passing across 7 filesScoped to the
stack-clipackage (where the change lives), not a full-monorepoyarn test.