Repository navigation
accept iterable inputs in write_lines type annotation - #259
Open
gheshm-jpg wants to merge 1 commit into
Open
gheshm-jpg wants to merge 1 commit into
gheshm-jpg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_linesaccepts tuples and generators at runtime, but itslist[str]annotation makes mypy reject both. the implementation already forwards its input to_replace_linesep, which acceptsIterable[str].this broadens the public annotation to
Iterable[str]and updates the parameter documentation. a typed regression test writes a tuple, appends a generator, and checks newline normalization and the resulting file contents.validation on macOS with Python 3.13.7:
python -m pytest -q: 161 passed, 1 skipped, and 7 ruff failures. the unchanged base reports 160 passed, 1 skipped, and the same 7 ruff failures with Ruff 0.16.6.git diff --checkpassed.no runtime implementation changes.