Skip to content

Preserve sparse frame IDs through pose graph optimization - #7622

Open
Afloat16 wants to merge 3 commits into
isl-org:mainfrom
Afloat16:fix-sparse-pose-graph-wrapper
Open

Afloat16 wants to merge 3 commits into
isl-org:mainfrom
Afloat16:fix-sparse-pose-graph-wrapper

Conversation

@Afloat16

@Afloat16 Afloat16 commented Nov 7, 2026

Copy link
Copy Markdown

The example built its frame-ID map in the reverse direction and then used graph indices as frame IDs when updating the optimized poses. Translate sparse IDs in both directions, report dangling edges before passing them to Open3D, and scope debug verbosity to the optimization. The command-line example now calls the existing solve_ method.

Validation: five Python regression checks with a lightweight stand-in for Open3D graph containers and the optimizer failed against main and passed with these changes. Native Open3D optimization was not exercised locally.

@update-docs

update-docs Bot commented Nov 7, 2026

Copy link
Copy Markdown

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Refresh the branch for upstream checks while preserving the sparse frame-ID mapping changes and changelog entry.
@Afloat16

Copy link
Copy Markdown
Author

The requested CHANGELOG entry is included, and df8de6f18bc068026c6b88ee743fa411fe965ef5 now merges current main (2ce4f7e0) into this branch without rewriting the existing commits.

The sparse-frame-ID fix is unchanged: the Python source matches the preceding PR head byte for byte, its syntax compilation passes, and Codacy has passed on the new head. The diff against main remains limited to the pose-graph example and its changelog entry.

The new Ubuntu workflow, Style Check, and remaining platform workflows are action_required with no jobs started. Could a maintainer approve these current-head runs so the official checks can execute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant