[PB-6629] Add preview decryption + mobile fixes#67
Open
TamaraFinogina wants to merge 8 commits into
Open
Conversation
xabg2
reviewed
Jul 22, 2026
Comment on lines
+80
to
+82
| if (error instanceof EmailHybridDecryptionError) throw error; | ||
| if (error instanceof EmailPreviewSymmetricDecryptionError) throw error; | ||
| throw new FailedToDecryptEmail(error instanceof Error ? error.message : String(error)); |
There was a problem hiding this comment.
If decryptKeysHybridand decryptPreview throws an error, there's no need to wrap this in a try/catch. The error will be propagated automatically.
Contributor
Author
There was a problem hiding this comment.
Hmm, true, I'll remove it then
xabg2
reviewed
Jul 22, 2026
| } | ||
| } | ||
|
|
||
| export class EmailPreviewSymmetricDecryptionError extends Error { |
There was a problem hiding this comment.
Also, add the name of the error here:
this.name = 'EmailPreviewSymmetrictDecryptionError' so we can use it in the client if we need to filter errors. Better using the name rather than status codes, messages or whatever.
TamaraFinogina
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a function for preview decryption only.
Remove WebCrypto from dec/enc symmetrically for mobile
Change base64 convertion for mobile
Checklist
Testing Process
unit tests
Additional Notes
Summaries of emails have no encrypted body or sessionKey, so the email decryption function can be called only with a trick of using the same preview 3 times to construct email-like looking structure. It can be avoided with this PR