Guard deconstructRegistration against null Registration

[imSzukala]

What

Adds a null guard at the top of IntercomHelpers.deconstructRegistration(...) so it returns an empty WritableMap when the Registration is null, instead of crashing.

Why

Intercom.client().fetchLoggedInUserAttributes() returns null by design when no user is logged in — the native Android SDK documents this (fetchLoggedInUserAttributes(): Registration?). This happens, for example, after the OS kills and restarts the app process (clearing the in-memory native session) and the app calls fetchLoggedInUserAttributes() before re-registration completes.

Both oldarch and newarch IntercomModule.fetchLoggedInUserAttributes() pass that return value straight into deconstructRegistration(...):

Registration registration = Intercom.client().fetchLoggedInUserAttributes(); // can be null
promise.resolve(IntercomHelpers.deconstructRegistration(registration));       // no null check

deconstructRegistration then dereferences registration.getEmail() on its first line, throwing a fatal NullPointerException on the JS bridge thread (UncaughtExceptionHandler → process death).

This is a platform parity gap: the iOS bridge (IntercomAttributesBuilder.dictionaryForUserAttributes:) reads attributes on a possibly-nil ICMUserAttributes and, thanks to Obj-C nil-messaging, resolves an empty dictionary ({}) for the same "no logged-in user" case. The fix brings Android to the same behavior, which also satisfies the existing non-nullable TS contract fetchLoggedInUserAttributes: () => Promise<UserAttributes>.

The native Android SDK is correct and unchanged — the nullable return is by design; only the RN bridge needed the guard. Pre-existing bug, not a regression (present in every release from 9.8.0 onward).

Crash (production)

java.lang.NullPointerException: Attempt to invoke virtual method
'java.lang.String io.intercom.android.sdk.identity.Registration.getEmail()' on a null object reference
  at com.intercom.reactnative.IntercomHelpers.deconstructRegistration
  at com.intercom.reactnative.IntercomModule.fetchLoggedInUserAttributes

Tests

The android/ library module has no JUnit/Robolectric test harness, and deconstructRegistration depends on RN's Arguments.createMap() bridge runtime. Standing up a test harness is out of scope for this one-line fix; the change is a straightforward null guard with a behavior matching the already-shipped iOS path.

Related

• Internal issue: intercom/intercom#520691

~ Automated via Claude