Typed operations - #704
Open
desmonddak wants to merge 7 commits into
Open
Conversation
Exact cumulative tree from original branch 494c892f5a7ee843885188c794226ef20ec2de71 in the netlist-first merge order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Our ROHD operations flatten attached structured signals,
LogicArrayandLogicStructuretoLogic, and we lose abstraction. This is especially noticeable when composing modules that share these structured types, and it shows up when we netlist or produce other outputs that could retain this structure.Really, a
Muxcan be interpreted as aMux<T>where the baseline case isMux<Logic>. We know the data input is the actual type, and so we can even infer the output type. Tricky cases exist when we pass inConst, so those need careful handling.Note that this also needs to handle the new
LogicArrayOftype, so this PR is based on PR #686.This PR also has support for
ConstLogicStructureto support fixing ROHD-HCL Issue#200.Related Issue(s)
Testing
All existing tests pass. Several new tests, including some changes to the netlister, help validate this approach.
Backwards-compatibility
No.
Documentation
Yes. Changes were added to mentions of the operators and in the
LogicStructureandLogicArrayareas.