Skip to content

Fst Writer - #671

Open
desmonddak wants to merge 4 commits into
intel:mainfrom
desmonddak:fst
Open

Fst Writer#671
desmonddak wants to merge 4 commits into
intel:mainfrom
desmonddak:fst

Conversation

@desmonddak

Copy link
Copy Markdown
Contributor

Description & Motivation

It would be nice to have a WaveDumper that can output the FST format because it is much more dense and can be incrementally accessed.

Related Issue(s)

None

Testing

We ran the output through a few tools, notably Wellen and GTKwave.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No. We will need to add. But at the user level, it becomes a choice between VCD and FST>

Comment thread lib/src/fst/fst_types.dart Outdated
Comment thread lib/src/wave_dumper.dart Outdated
Comment thread lib/src/wave_dumper.dart Outdated
Comment thread lib/rohd.dart
Comment thread test/fst_writer_test.dart

@mkorbel1 mkorbel1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reviewed some of the FST-specific pieces, generally looks good, but I'll defer full review until the common pieces in prior PRs are merged first

Comment thread test/wave_dumper_test.dart Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make tests that dump FST, convert to VCD, then confirm the right values at the right time like we already do for VCD? and/or some other way to make sure that actual simulations make the right values at the right time? i think some of these VCD checking tests were catching actual tricky spots.

@desmonddak
desmonddak force-pushed the fst branch 2 times, most recently from 9f3c34f to 8e95fe6 Compare August 24, 2026 22:51
desmonddak and others added 4 commits September 4, 2026 00:05
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants