Fix Wan batch conditioning and config handling#13693
Open
hlky wants to merge 1 commit intohuggingface:mainfrom
Open
Fix Wan batch conditioning and config handling#13693hlky wants to merge 1 commit intohuggingface:mainfrom
hlky wants to merge 1 commit intohuggingface:mainfrom
Conversation
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13578.
What does this PR do?
This PR addresses the Wan systemic review findings:
batch_size * num_videos_per_promptin per-prompt order.imagerequired where VAE conditioning still needs it, while allowing precomputed CLIPimage_embeds.output_type="latent".num_videos_per_prompt != 1..ai/pipelines.mdchecklist note fornum_*_per_promptexpansion drift.Tests
ruff check ...on touched Python filesruff format --check ...on touched Python filesgit diff --checkpython -m compileall -q src/diffusers/pipelines/wan src/diffusers/modular_pipelines/wan tests/pipelines/wan tests/modular_pipelines/wanpython -m pytest tests/pipelines/wan/test_wan_image_to_video.py tests/pipelines/wan/test_wan_vace.py tests/pipelines/wan/test_wan_video_to_video.py tests/pipelines/wan/test_wan_animate.py tests/modular_pipelines/wan/test_modular_pipeline_wan.py -q -k "not test_save_load_float16"Result:
180 passed, 21 skipped, 5 deselected, 61 warnings, 6 subtests passed.Note:
WanFLFToVideoPipelineFastTests::test_save_load_float16fails the same way on cleanupstream/main(max diff 0.04175 > 0.01), so it was excluded from the clean touched-file verification.