fix(CI-CD): don't treat a shard's zero-mutant files as a failure - #163
Merged
Conversation
The very first sharded run failed: merge-shards.ts required every file in a shard's manifest to have an entry in that shard's report, but Stryker omits a file from `files` entirely when it has no mutable code — confirmed against main's pre-sharding baseline, which already excluded the same 20 files (pure type/interface declarations under helpers/type/, plus a handful of types.ts/_types.ts files elsewhere), 296 of the 316 mutable files total. A shard whose job genuinely fails never produces mutation.json at all — Stryker writes the whole report in one shot at the end, so there's no partial version to misread — and that failure mode is what the shard-artifact-count check already catches. This was verified against the actual failed run's logs (2026-09-08T10:49Z) before writing the fix, and re-verified locally against the same fixtures used for the original merge script tests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ PR Validation Passed
📋 Pipeline Status
📊 Code Coverage
🧬 Mutation Testing
🌐 Runtime Compatibility
⏱️ Benchmarks
ℹ️ About this report
🤖 Generated by @helpers4 CI • 2026-09-08 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filesmap entirely.merge-shards.tsno longer treats an absent file as an error; it's counted and logged as a zero-mutant skip instead. The shard-artifact-count check (catching a shard that fails before it can even upload) is untouched — that's the actual failure signal, since Stryker only ever writes its report in one complete shot at the end of a run.Test plan
pnpm run typecheck/pnpm run lintclean🤖 Generated with Claude Code