Reduce Shiki loading with the JavaScript regex engine - #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The default Shiki bundle uses the WebAssembly-based Oniguruma engine. Opening the comment editor or rendering a comment containing code previously required loading an approximately 232 kB gzip WASM chunk.
The custom bundle removes the Oniguruma dependency and reduces the editor Shiki loading path from approximately 306.8 kB to 95.7 kB gzip.
Validation
pnpm -C packages/comment-widget testpnpm exec tsc -p packages/comment-widget/tsconfig.json --noEmitpnpm exec biome check package.json packages/comment-widget/vite.config.ts packages/comment-widget/src/comment-content.ts packages/comment-widget/src/shiki-bundle.ts packages/comment-widget/tests/shiki-bundle.test.tspnpm buildWebAssembly.instantiatenor the Oniguruma engine