Add optional project reference support for local Terminal.Gui development#1
Conversation
When TerminalGuiRoot is set (e.g. -p:TerminalGuiRoot=../Terminal.Gui), the NuGet PackageReference is replaced with a ProjectReference to the local Terminal.Gui source. This enables immediate detection of breaking changes during Terminal.Gui development. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ab02048bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ProjectReference paths in Directory.Build.targets are evaluated relative to each importing .csproj. This normalizes TerminalGuiRoot to an absolute path based on the repo root (where Directory.Build.props lives), so relative paths like '../Terminal.Gui' work correctly regardless of which project directory the build is invoked from. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Addressed the review feedback in 0a957cc: |
When
TerminalGuiRootis set (e.g.dotnet build -p:TerminalGuiRoot=../Terminal.Gui), the NuGet PackageReference for Terminal.Gui is replaced with a ProjectReference to the local source. This enables immediate detection of incompatibilities during Terminal.Gui development.Changes
UseLocalTerminalGui=truewhenTerminalGuiRootis providedRelated: gui-cs/Terminal.Gui#5402