Add loaded status by root network by ghazwarhili · Pull Request #1072 · gridsuite/study-server

ghazwarhili · 2026-08-25T15:48:26Z

PR Summary

RootNetworkLoadStatus (LOADED, UNLOADED, UNLOADING) carried by root_network.load_status (migration, default LOADED for existing rows)

Two new supervision endpoints:

DELETE /supervision/studies/{studyUuid}/invalidate for each root network: unbuild all nodes, delete the network in network-store, transition through UNLOADING then UNLOADED
GET /supervision/studies/loaded returns among the given ids the studies that have at least one root network LOADED

Transitions:

new root network → LOADED (entity default, confirmed once import actually succeeds)
LOADED → UNLOADING → UNLOADED: DELETE /invalidate
UNLOADED → LOADED: successful case re-import (reopening a study whose network had been unloaded)
UNLOADED stays UNLOADED: re import failure

coderabbitai · 2026-08-25T15:48:35Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 696d34a0-4ced-40ed-abb3-cad390542fdc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

etiennehomer · 2026-08-28T16:00:25Z

+public enum NetworkLoadStatus {
+    LOADED,
+    UNLOADED,
+    LOADING,


etiennehomer · 2026-08-28T16:11:28Z

    private RootNetworkIndexationStatus indexationStatus = RootNetworkIndexationStatus.NOT_INDEXED;

+    @Enumerated(EnumType.STRING)
+    @Column(name = "network_load_status")


Suggested change

@Column(name = "network_load_status")

@Column(name = "load_status")

etiennehomer · 2026-08-28T16:11:46Z

+/**
+ * @author Ghazwa Rehili <ghazwa.rehili at rte-france.com>
+ */
+public enum NetworkLoadStatus {


Suggested change

public enum NetworkLoadStatus {

public enum RootNetworkLoadStatus {

etiennehomer · 2026-08-28T16:11:56Z

+    @Enumerated(EnumType.STRING)
+    @Column(name = "network_load_status")
+    @Builder.Default
+    private NetworkLoadStatus networkLoadStatus = NetworkLoadStatus.LOADED;


Suggested change

private NetworkLoadStatus networkLoadStatus = NetworkLoadStatus.LOADED;

private NetworkLoadStatus loadStatus = NetworkLoadStatus.LOADED;

etiennehomer · 2026-08-28T16:23:02Z

                removeReimportCaseActivity(studyUuid, rootNetworkUuid);
            }
+            if (!success && caseImportAction == CaseImportAction.NETWORK_RECREATION) {
+                rootNetworkService.updateNetworkLoadStatusIfCurrent(rootNetworkUuid, NetworkLoadStatus.LOADING, NetworkLoadStatus.UNLOADED);


Too complicated. Just set to LOADED after network recreation

etiennehomer · 2026-08-28T16:26:33Z

        if (receiver.getCaseImportAction() == CaseImportAction.ROOT_NETWORK_MODIFICATION) {
            removeReimportCaseActivity(receiver.getStudyUuid(), receiver.getRootNetworkUuid());
        }
+        if (receiver.getCaseImportAction() == CaseImportAction.NETWORK_RECREATION) {


Here it's a fail. Just set to UNLOADED if UNLOADING

etiennehomer · 2026-08-28T16:26:53Z

+    }
+
+    @Transactional
+    public void updateNetworkLoadStatusIfCurrent(UUID rootNetworkUuid, NetworkLoadStatus expectedCurrentStatus, NetworkLoadStatus networkLoadStatus) {


I remove also the endpoint getLoadedStudies ?

etiennehomer · 2026-08-28T16:29:19Z


-        persistNetwork(rootNetworkInfos, studyUuid, null, userId, importParametersToUse, CaseImportAction.NETWORK_RECREATION, reportId);
-        notificationService.emitElementUpdated(studyUuid, userId);
+        rootNetworkService.updateNetworkLoadStatus(rootNetworkInfos.getId(), NetworkLoadStatus.LOADING);


All changes here to remove. We don't use LOADING

etiennehomer · 2026-08-28T16:29:51Z

        RootNetworkEntity rootNetworkEntity = rootNetworkService.getRootNetwork(rootNetworkUuid).orElseThrow(() -> new StudyException(NOT_FOUND, "Root network not found"));

        rootNetworkService.updateNetwork(rootNetworkEntity, networkInfos);
+        rootNetworkEntity.setNetworkLoadStatus(NetworkLoadStatus.LOADED);


Why do you need this ?

to update the status to LOADED ? you suggest to be removed also ?

etiennehomer · 2026-08-28T16:30:57Z

                .toList();
        CompletableFuture.allOf(futures.toArray(CompletableFuture[]::new)).join();
-        notificationService.emitElementUpdated(studyUuid, userId);
+        boolean allRootNetworkLoaded = rootNetworkIds.stream()


If "at least one network is loaded", then you notify. Not needed to be all LOADED

sonarqubecloud · 2026-09-01T09:18:08Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ghazwarhili added 4 commits August 19, 2026 09:16

network load status

330221d

remove emitElementUpdated

74a7397

resolve conflicts

1edcd38

add network load status by root network

927faf9

ghazwarhili added 2 commits August 26, 2026 11:34

add TU

7270e62

remove UNLOADING enum

8b242cc

ghazwarhili requested a review from etiennehomer August 26, 2026 13:11

ghazwarhili added 7 commits August 26, 2026 15:28

some fix to avoid race condition

01f3248

some fix

98fb17b

resolve conflicts

85c33fe

code review remarks

414f076

clean unused code

15c7fc7

Merge branch 'main' into add-loaded-status-by-root-network

13f735b

send element update only all root network are loaded

4ae1923

etiennehomer requested changes Aug 28, 2026

View reviewed changes

code rev iew remarks

f42459f

ghazwarhili requested a review from etiennehomer September 1, 2026 08:31

ghazwarhili added 3 commits September 1, 2026 10:35

update TU

352d82e

renaming

0f377b4

sonar issue

83628d5

	@Column(name = "network_load_status")
	@Column(name = "load_status")

	public enum NetworkLoadStatus {
	public enum RootNetworkLoadStatus {

	private NetworkLoadStatus networkLoadStatus = NetworkLoadStatus.LOADED;
	private NetworkLoadStatus loadStatus = NetworkLoadStatus.LOADED;

Uh oh!

Conversation

ghazwarhili commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

coderabbitai Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 1, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghazwarhili commented Aug 25, 2026 •

edited

Loading

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading