feat: use standalone Filter in assignmenents modifications - #223
Open
TheMaskedTurtle wants to merge 11 commits into
Open
feat: use standalone Filter in assignmenents modifications#223TheMaskedTurtle wants to merge 11 commits into
TheMaskedTurtle wants to merge 11 commits into
Conversation
TheMaskedTurtle
requested review from
EtienneLt,
SlimaneAmar and
etiennehomer
as code owners
August 25, 2026 13:20
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TheMaskedTurtle
force-pushed
the
jorism/feat/use-filter-in-assignments
branch
from
August 25, 2026 15:31
8a1e34f to
39d9fca
Compare
KoloMenek
self-requested a review
August 28, 2026 07:59
KoloMenek
requested changes
Aug 28, 2026
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
jorism/feat/use-filter-in-assignments
branch
from
August 31, 2026 14:25
606827a to
52e0641
Compare
KoloMenek
approved these changes
Aug 31, 2026
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Starting the migration of modification so that they can really be standalone. Starting by inheritors of AbstractAssignmentModification which are ByFormulaModification and ModificationByAssignment.
For that I had to:
Also, reports were not used properly towards the ReportNode interface, I adjusted that as well in the related classes.