Skip to content

feat: use new standalone FilterLoader - #876

Open
TheMaskedTurtle wants to merge 5 commits into
mainfrom
jorism/feat/use-filter-in-assignments
Open

feat: use new standalone FilterLoader#876
TheMaskedTurtle wants to merge 5 commits into
mainfrom
jorism/feat/use-filter-in-assignments

Conversation

@TheMaskedTurtle

@TheMaskedTurtle TheMaskedTurtle commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

  • Implement and use the new FilterLoader interface
  • Adapt tests

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a255d0ae-d84d-49d9-80b7-9a06216dfeda

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheMaskedTurtle
TheMaskedTurtle force-pushed the jorism/feat/use-filter-in-assignments branch 2 times, most recently from b0d46f6 to cfb7054 Compare August 27, 2026 14:27
@KoloMenek
KoloMenek self-requested a review August 28, 2026 07:59
KoloMenek
KoloMenek requested changes Aug 28, 2026
View reviewed changes

@KoloMenek KoloMenek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works fine. Few comments for the code.

Comment thread src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java Outdated
Comment thread src/main/java/org/gridsuite/modification/server/service/FilterLoader.java Outdated
Comment thread ...er/modifications/byfilter/assignment/TwoWindingsTransformerModificationByAssignmentTest.java Outdated
Comment thread ...n/server/modifications/byfilter/formula/TwoWindingsTransformerByFormulaModificationTest.java Outdated
Comment thread ...te/modification/server/modifications/byfilter/formula/AbstractByFormulaModificationTest.java Outdated
Comment thread ...te/modification/server/modifications/byfilter/formula/AbstractByFormulaModificationTest.java
Comment thread ...ification/server/modifications/byfilter/assignment/AbstractModificationByAssignmentTest.java
@KoloMenek

KoloMenek commented Aug 28, 2026

Copy link
Copy Markdown
Member

While doing additional tests using the ExpertFilters, I got an error cause by a dependency version mismatch for org.apache.commons:commons-lang3:jar that is on version 3.17.0 in network-modification-server and 3.20.0 in filter library. I proposed a solution that makes the filter library no longer use this library, fixing this issue. Here is the PR: gridsuite/filter#132

@TheMaskedTurtle
fix imports on moved classes and implement/use new FilterLoader
a875d82 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
fix tests
82708a8 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
refactor: factorize tests
41d2574 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
improve flexibility of stubs
cc17937 
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
@TheMaskedTurtle
TheMaskedTurtle force-pushed the jorism/feat/use-filter-in-assignments branch from 110f301 to cc17937 Compare September 1, 2026 07:30
@TheMaskedTurtle
review fixes
331e3da 
- change getNewFilters to load
- use query params
- improve query params tests
- improve twt tests

Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoloMenek KoloMenek KoloMenek approved these changes

Assignees

@TheMaskedTurtle TheMaskedTurtle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheMaskedTurtle @KoloMenek