fix: keep the referenceId when loading a modification reference metadata

[flomillot]

PR Summary

On the metadata path, loadModificationReference returned a bare ModificationInfos: the entity comes from a
projection which strips the subclass, so the reference attributes — referenceId included — were lost, and
clients could not tell which shared element a shared modification points to.

The referenced modification is already fetched on that path to get its message type and values, and its id is
precisely the referenceId. That branch now builds a ModificationReferenceInfos carrying it.

Touches the same method as #852, which changes the other branch of the same if.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 69d08039-895a-41f7-ad7b-8a50bd796a56

📝 Walkthrough

Walkthrough

Changes

Modification reference metadata resolution

Layer / File(s)	Summary
Resolve and validate reference metadata src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java, src/test/java/org/gridsuite/modification/server/ModificationControllerTest.java	Metadata-only reference projections now return ModificationReferenceInfos using the referenced modification’s identifier and message metadata, throw when the referenced modification is missing, and verify the deserialized type and resolved fields through an integration test.

Suggested reviewers: meklo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: preserving referenceId in modification reference metadata loading.
Description check	✅ Passed	The description is directly related to the code changes and explains the metadata-path fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud