chore(wip-identifier-list-filter): fix typo - #130
Conversation
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
📝 WalkthroughWalkthroughThe list-filter report key changed from ChangesEquipment Type Report Key
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/org/gridsuite/filter/report_fr.properties`:
- Line 1: Update the filter.evaluation.listFilter.allFound French message to use
the accented “éléments” in the count phrase after ${searchCount}, matching the
wording already used later in the same message.
In `@src/main/resources/org/gridsuite/filter/report.properties`:
- Line 2: Update the filter.evaluation.listFilter.emptyResult message to remove
the duplicated “elements” and use the consistent separator before “no elements
found”; update the corresponding exact expected text in IdentifierListFilterTest
to match.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b7e6b2c1-caa2-4905-94c3-127ee4ecf46d
📒 Files selected for processing (4)
src/main/java/org/gridsuite/filter/wip/IdentifierListFilter.javasrc/main/resources/org/gridsuite/filter/report.propertiessrc/main/resources/org/gridsuite/filter/report_fr.propertiessrc/test/java/org/gridsuite/filter/wip/IdentifierListFilterTest.java
| filter.evaluation.listFilter.allFound=Application d'un filtre par nommage avec ${searchCount} elements (type ${equipementType}) : tous les éléments ont pu être trouvés | ||
| filter.evaluation.listFilter.emptyResult=Application d'un filtre par nommage avec ${searchCount} éléments (type ${equipementType}) : aucun élément trouvé | ||
| filter.evaluation.listFilter.notFound=Application d'un filtre par nommage avec ${searchCount} éléments (type ${equipementType}) : ${notFoundCount} éléments n'ont pas pu être trouvés | ||
| filter.evaluation.listFilter.allFound=Application d'un filtre par nommage avec ${searchCount} elements (type ${equipmentType}) : tous les éléments ont pu être trouvés |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the accented form in the count phrase.
The all-found message still renders elements without the accent in avec ${searchCount} elements. Use éléments there, as already used later in the same message.
This finding is based on the supplied French template.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/org/gridsuite/filter/report_fr.properties` at line 1,
Update the filter.evaluation.listFilter.allFound French message to use the
accented “éléments” in the count phrase after ${searchCount}, matching the
wording already used later in the same message.
| filter.evaluation.listFilter.emptyResult=Applying list filter of ${searchCount} elements (type ${equipementType}) elements no elements found | ||
| filter.evaluation.listFilter.notFound=Applying list filter of ${searchCount} elements (type ${equipementType}) : ${notFoundCount} elements not found | ||
| filter.evaluation.listFilter.allFound=Applying list filter of ${searchCount} elements (type ${equipmentType}) : all elements found | ||
| filter.evaluation.listFilter.emptyResult=Applying list filter of ${searchCount} elements (type ${equipmentType}) elements no elements found |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the empty-result English message.
The message currently renders ... (type ${equipmentType}) elements no elements found. Remove the duplicated elements and keep the separator consistent, for example ... (type ${equipmentType}) : no elements found. Update the exact assertion in IdentifierListFilterTest.java if the text changes.
This finding is based on the supplied English template and its existing test assertion.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/org/gridsuite/filter/report.properties` at line 2, Update
the filter.evaluation.listFilter.emptyResult message to remove the duplicated
“elements” and use the consistent separator before “no elements found”; update
the corresponding exact expected text in IdentifierListFilterTest to match.
1 participant
PR Summary