Introduce GraphQL-over-HTTP response - #423
Open
martinbonnin wants to merge 4 commits into
Open
Conversation
This was referenced Aug 11, 2026
magicmark
reviewed
Aug 17, 2026
Comment on lines
+544
to
+545
| contain the {errors} entry, then the server SHOULD reply with a `200` status | ||
| code. |
There was a problem hiding this comment.
just curious why this is SHOULD? what other status code would be acceptable here? (in theory i could see something like a 201 on mutation, so i could see someone trying to be a good REST citizen and implementing that)
(I realize this is an existing wording and probably already discussed)
Contributor
Author
There was a problem hiding this comment.
201 is the reason. Or more general make sure that clients to not do == 200 checks in case we want to use other codes in the future.
magicmark
approved these changes
Aug 17, 2026
Shane32
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like there is
GraphQL-over-HTTP request, this PR introducesGraphQL-over-HTTP response.Using GraphQL response was misleading because the HTTP specification doesn't say anything about response streams and we might end up using a separate media type for this (
application/graphql-responses+jsonl, ...)Instead, this PR introduces a new
GraphQL-over-HTTP responsethat is either an execution result or a request error result, but not a response stream.