Skip to content

fix: added thumbnail to bookmarked items#1245

Merged
Santirv17 merged 8 commits into
mainfrom
fix/folder-bookmark-thumbnail
Jun 9, 2026
Merged

fix: added thumbnail to bookmarked items#1245
Santirv17 merged 8 commits into
mainfrom
fix/folder-bookmark-thumbnail

Conversation

@Santirv17

@Santirv17 Santirv17 commented May 29, 2026

Copy link
Copy Markdown
Contributor

Fix bookmark folder cards so they display folder thumbnails and keep the same layout when entering manage mode.

Bookmarks now use the thumbnail URL provided on item.thumbnails?.medium.

  • Added a BookmarkThumbnails file for BookmarkCard and BookmarkCardEdit
  • Replaces ItemThumbnail import to CardThumbnail and moved it to BookmarkThumbnails

Before:
Screenshot 2026-06-01 151538

After:
Screenshot 2026-05-29 130254

The manage-mode bookmark cards were also adjusted so pressing 'Manage' does not change the card height or misalign the thumbnail/text layout.

  • Modified 'BookmarkCardEdit' to maintain same visual property while in both modes

Before:
Screenshot 2026-05-29 122201

After:
Screenshot 2026-05-29 130553

@Santirv17
Santirv17 requested a review from spaenleh May 29, 2026 12:57
@Santirv17 Santirv17 self-assigned this May 29, 2026
@Santirv17 Santirv17 closed this Jun 1, 2026
@Santirv17 Santirv17 changed the title Fix bookmark thumbnail layout and 'manage-mode' layout fix: added thumbnail to bookmarked items Jun 1, 2026
@Santirv17 Santirv17 reopened this Jun 1, 2026

@spaenleh spaenleh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for your work on this. I really appreciate your effort of ensuring the layout stays the same between the edit and display state of the bookmark.
As a small note I was confused since the screenshots do not show the same padding on the side (I think you made that adjustment later and the screenshots were not updated, so I checked the code to be sure).

Overall changes look good. If I had to nitpick, I think it is not necessary to create the BookmarkThumbnail component just to set the height to a constant value. Another note is that most of the code inside the CardActionAreaLink and the CardContent for the edited and display versions is the same. Or at least they try to look the same but have small code inconsistencies. I would maybe make that part a common component instead and directly call the CardThumbnail in place of the BookmarkThumbnail an remove that extra component definition.

But again this is being a bit nitpicky. I would recommend looking at the code of both components side by side so you can see clearly the differences and the similarity. The paddingRight is set at different levels for example.

@Santirv17

Santirv17 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

I have read and applied your recommendations on the code. I removed BookmarkThumbnail and moved it's logic to both BookmarkCard and BookmarkCardEdit. I also removed some unused paddingRight code and moved the correct one to match styles in both files.

As for the earlier screenshots, you were right, they were outdated in comparison to the final code as I made some layout changes/fixes after taking the screenshot.

@spaenleh spaenleh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes. I have added 2 comments, but I will approve now and let you fix them before merging. 💯

Comment thread src/modules/home/bookmarks/BookmarkCard.tsx Outdated
Comment thread src/modules/home/bookmarks/BookmarkCardEdit.tsx Outdated
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

@Santirv17
Santirv17 added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 5fbf1b9 Jun 9, 2026
5 checks passed
@Santirv17
Santirv17 deleted the fix/folder-bookmark-thumbnail branch June 9, 2026 09:48
@spaenleh

spaenleh commented Jul 1, 2026

Copy link
Copy Markdown
Member

@allcontributors please add @Santirv17 for code

@allcontributors

Copy link
Copy Markdown
Contributor

@spaenleh

I've put up a pull request to add @Santirv17! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants