feat(translate-v2): enable self-signed JWT by default#33974
Open
quartzmo wants to merge 1 commit into
Open
Conversation
Member
quartzmo
commented
May 20, 2026
quartzmo
commented
- Update Gemfile to allow google-style ~> 1.31.1.
- Add ostruct to Gemfile for Ruby 4.0.0+ compatibility.
- Fix test stubs to accept positional hash for Ruby 3+ keyword separation.
* Update Gemfile to allow google-style ~> 1.31.1. * Add ostruct to Gemfile for Ruby 4.0.0+ compatibility. * Fix test stubs to accept positional hash for Ruby 3+ keyword separation.
aandreassa
reviewed
May 21, 2026
| gem "google-cloud-core", path: "../google-cloud-core" | ||
| gem "google-cloud-errors", path: "../google-cloud-errors" | ||
| gem "google-style", "~> 1.30.1" | ||
| gem "google-style", "~> 1.31.1" |
| gem "google-cloud-errors", path: "../google-cloud-errors" | ||
| gem "google-style", "~> 1.30.1" | ||
| gem "google-style", "~> 1.31.1" | ||
| gem "ostruct" |
Contributor
There was a problem hiding this comment.
Nit: add a version, like ~> 0.6.3
| # translation.text #=> "Salve mundi!" | ||
| # | ||
| def self.new project_id: nil, credentials: nil, key: nil, scope: nil, retries: nil, timeout: nil, endpoint: nil | ||
| def self.new project_id: nil, credentials: nil, key: nil, scope: nil, retries: nil, timeout: nil, endpoint: nil, enable_self_signed_jwt: nil |
Contributor
There was a problem hiding this comment.
Missing docstring for enable_self_signed_jwt
aandreassa
requested changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.