refactor(pubsub): remove EOL Python 3.7/3.8/3.9 false positives and compatibility checks#17485
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.9, raising the minimum supported version to Python 3.10. This allows for the cleanup of various legacy compatibility checks, imports, and test skips across the codebase. Feedback on the changes suggests that passing cancel_futures=True to self._executor.shutdown() in scheduler.py is redundant because the manual queue draining loop already empties the work queue.
febd106 to
a41b0d8
Compare
chalmerlowe
commented
Jun 16, 2026
78f316d to
c3d2762
Compare
c3d2762 to
bc1cf42
Compare
ohmayr
reviewed
Jun 17, 2026
ohmayr
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
google-cloud-pubsubrequires Python >= 3.10, this PR cleans up obsolete compatibility checks, warnings, and pytest skip conditions targeting Python 3.7, 3.8, and 3.9.Why this is needed:
🦕