Repository navigation
test(Firestore): stop warnings in the update-paths conformance test - #9773
Open
rootkiller6788 wants to merge 1 commit into
Open
rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
The 'update-paths: no paths' conformance case has no fieldPaths key, so the foreach in testUpdatePaths() warned twice on every run. Pass an empty list instead, which also means update() actually gets called with no data - the case expects a client-side error there.
product-auto-label
Bot
added
the
api: firestore
rootkiller6788
marked this pull request as ready for review
October 7, 2026 04:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9100.
testUpdatePaths()loops over$test['fieldPaths'], but theupdate-paths: no pathscase doesn't have that key - it only carriesdocRefPathandisError. That gave two warnings on every run:I used
?? []so the case still runs andupdate()gets called with an empty list, which is what that case is actually about - its own comment says "It is a client-side error to call Update with empty data."One thing worth knowing: the test was already green.
executeAndHandleError()catches\Exception, and PHPUnit turns the warning intoPHPUnit\Framework\Error\Warning, which extends\Exception- so the warning itself was being counted as the expected error, and the assertion wasn't really checking anything. Now the exception comes from the client's own empty-data check instead.Ran
vendor/bin/phpunitunderFirestore/with PHP 8.4.25 and grpc 1.84.0: 723 tests, 2758 assertions, OK (13 skipped), same as before the change.