Repository navigation
Conversation
…nd RapidCache APIs Removes `skip_generate` from `google-storage-control` in `librarian.yaml`, preserves sample fixtures and `webpack.config.js` in `keep`, and regenerates `@google-cloud/storage-control` with `ViewObjectFullContext`, `UpdateManagedFolder`, and `RapidCache` APIs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Rapid Cache and Object Context features in the Google Storage Control client, adding several new RPCs (such as UpdateManagedFolder, ViewObjectFullContext, and various Rapid Cache operations) along with their corresponding client library implementations, configurations, and tests. The review feedback highlights that the generation process for the Storage service has completely overwritten the gapic_metadata.json file, losing the metadata for StorageControl, which needs to be resolved upstream. Additionally, a minor grammatical typo was identified in a comment within the auto-generated storage_control.proto file that should also be corrected upstream.
| "libraryPackage": "@google-cloud/storage-control", | ||
| "services": { | ||
| "StorageControl": { | ||
| "Storage": { |
There was a problem hiding this comment.
It appears that gapic_metadata.json is being overwritten during the generation process. Since this package (@google-cloud/storage-control) contains both the StorageControl and Storage services, gapic_metadata.json should ideally contain metadata for both services. Currently, the generation of the Storage service has completely overwritten the metadata for StorageControl.
This is a common issue when multiple services are generated into the same package in separate generator runs, causing the last run to overwrite the metadata file. Please update the generator configuration or build scripts to ensure that the metadata for both services is merged, or that they are generated together to prevent one from overwriting the other.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
| } | ||
|
|
||
| // Lists the `IntelligenceFinding` resources for the specified project. | ||
| // Lists the `IntelligenceFinding` resources for the specified the project. |
There was a problem hiding this comment.
There is a grammatical typo in the comment: 'specified the project' should be 'specified project' (or 'specified organization, folder, or project'). Since this proto file is auto-generated, please do not edit it manually. Any changes or updates must be made upstream in the source definitions.
References
- Do not manually edit generated proto files. Any changes or updates must be made upstream in the source definitions.
…eat/storage-control-regenerate-v2
Removes
skip_generatefromgoogle-storage-controlinlibrarian.yaml, preserves sample fixtures andwebpack.config.jsinkeep, and regenerates@google-cloud/storage-controlwithViewObjectFullContext,UpdateManagedFolder, andRapidCacheAPIs. Related to #9836.