Repository navigation
Conversation
…g Object Re-runs `npm run compile-protos` inside `packages/google-storage-control/librarian.js` after `storage_control_utils.js` renames `message Object` to `message StorageObject` in `storage.proto` so `protos/protos.js` does not shadow global `Object`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds an extra compile-protos execution step in librarian.js for the google-storage-control package. This step ensures that protos are re-compiled after storage_control_utils.js renames Object to StorageObject, preventing the generated JS code from shadowing the global JavaScript Object class. There are no review comments, and I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-runs
npm run compile-protosinsidepackages/google-storage-control/librarian.jsafterstorage_control_utils.jsrenamesmessage Objecttomessage StorageObject, preventingpbjsfrom shadowing globalObject.defineProperty(b/582921805).