Skip to content

feat(generator): emit callable getter and convenience method for resumable upload RPCs - #14319

Draft
whowes wants to merge 1 commit into
whowes/generator-settings-codegenfrom
whowes/generator-client-codegen
Draft

feat(generator): emit callable getter and convenience method for resumable upload RPCs#14319
whowes wants to merge 1 commit into
whowes/generator-settings-codegenfrom
whowes/generator-client-codegen

Conversation

@whowes

@whowes whowes commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Generates the public client surface and base stub contracts for resumable upload RPCs, providing both an asynchronous ResumableUploadCallable and a synchronous InputStream method.

Test composers are updated with placeholder @Ignored tests to reflect that meaningful testing is only exercised via integration tests (due to insufficient mock capabilities). Unit goldens are included to verify the generated surfaces.

@whowes
whowes added this pull request to stack #14327 September 9, 2026 06:35
gemini-code-assist[bot]

This comment was marked as outdated.

@whowes
whowes force-pushed the whowes/generator-client-codegen branch from a07c67a to e0d1fe6 Compare September 9, 2026 15:50
@whowes
whowes force-pushed the whowes/generator-client-codegen branch from e0d1fe6 to c202895 Compare September 9, 2026 20:16
@whowes
whowes removed this pull request from stack #14327 September 9, 2026 23:45
@whowes
whowes added this pull request to stack #14343 September 9, 2026 23:47
@whowes
whowes force-pushed the whowes/generator-client-codegen branch 2 times, most recently from 39fdadf to 775a413 Compare September 10, 2026 00:19
@whowes
whowes force-pushed the whowes/generator-client-codegen branch from 775a413 to 3c5beaf Compare September 10, 2026 01:15
…mable upload RPCs

- In AbstractServiceStubClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() throwing UnsupportedOperationException
- In AbstractServiceClientClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() delegating to stub
- In AbstractServiceClientClassComposer: emit synchronous convenience method [method](RequestT request, InputStream payload) calling ApiExceptions.callAndTranslateApiException
- Suppress method variants (flattened methods) for resumable upload RPCs
- In ServiceClientCommentComposer: emit Javadoc call context override warning on both callable method and synchronous convenience method
- Add unit test ResumableUploadServiceClientComposerTest verifying generated stub and client methods
@whowes
whowes force-pushed the whowes/generator-client-codegen branch from 3c5beaf to 9297723 Compare September 10, 2026 06:05
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant