Skip to content

chore: modernize post-processing for common-protos, iam, and showcase#13779

Merged
blakeli0 merged 1 commit into
googleapis:mainfrom
yangyzs:chore-update-librarian-2026-07-15
Jul 16, 2026
Merged

chore: modernize post-processing for common-protos, iam, and showcase#13779
blakeli0 merged 1 commit into
googleapis:mainfrom
yangyzs:chore-update-librarian-2026-07-15

Conversation

@yangyzs

@yangyzs yangyzs commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Remove legacy owlbot.py scripts for java-common-protos, java-iam, and java-showcase, and migrate their configurations to librarian.yaml.

For googleapis/librarian#6832

Remove legacy owlbot.py scripts for java-common-protos, java-iam, and
java-showcase, and migrate their configurations to librarian.yaml.

For googleapis/librarian#6832
@yangyzs yangyzs requested review from a team as code owners July 15, 2026 18:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes legacy synthtool configuration files and migrates their settings to librarian.yaml, including adding README.md to the keep lists and specifying files to be removed post-processing. A review comment correctly identifies that common_resources.proto was omitted from the remove_file list in librarian.yaml, which is needed to maintain parity with the legacy configuration.

Comment thread librarian.yaml
Comment thread librarian.yaml
transport_override: grpc
skip_pom_updates: true
skip_api_id: true
keep:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC keep means that these files are excluded from regenerating? So they are generated once and never updated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. README.md in these libraries has never been updated or regenerated.

@yangyzs yangyzs requested review from JoeWang1127 and blakeli0 July 15, 2026 19:16
@blakeli0 blakeli0 merged commit f896639 into googleapis:main Jul 16, 2026
204 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants