feat(bigquery-jdbc): Migrate getImportedKeys and getCrossReference to BQ API#13692
Merged
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Contributor
Author
|
/gemini review |
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BigQueryDatabaseMetaData to retrieve imported keys and cross-references using Java API calls (bqTable.getTableConstraints()) instead of executing SQL queries from external files. This change removes the need for DatabaseMetaData_GetImportedKeys.sql and DatabaseMetaData_GetCrossReference.sql files, and simplifies constraint processing. There are no review comments, so I have no feedback to provide.
logachev
approved these changes
Jul 9, 2026
b/532245343 This PR migrates `BigQueryDatabaseMetaData.getExportedKeys()` from legacy `INFORMATION_SCHEMA` SQL queries to the native BigQuery Java SDK. This leverages the `TableConstraints` metadata directly, aligning it with the recent migrations of `getPrimaryKeys` and `getImportedKeys`. **Key Changes:** * **API Migration**: Rewrote `getExportedKeys` to use `TableConstraints` fetched via the native SDK, eliminating the need for `DatabaseMetaData_GetExportedKeys.sql`. * **Concurrent Scanning**: Upgraded `processTargetTablesConcurrently` to dynamically list and concurrently scan all tables across target datasets when a parent table isn't explicitly provided. * **Sorting Compliance**: Added `defineFkTableSortComparator` to correctly sort result sets by `FKTABLE_CAT`, `FKTABLE_SCHEM`, `FKTABLE_NAME`, and `KEY_SEQ` as strictly required by the JDBC spec. * **Code Cleanup**: Removed obsolete SQL constants, `.sql` resource files, and dead helper methods (`readSqlFromFile`, `replaceSqlParameters`). * **Testing**: Added new integration test `testGetExportedKeys`
keshavdandeva
added a commit
that referenced
this pull request
Jul 9, 2026
…` to BQ API (#13692) b/532249777 This PR migrates the `getImportedKeys` and `getCrossReference` JDBC metadata methods in `BigQueryDatabaseMetaData` to retrieve constraints natively via the Google Cloud Java Client API instead of running legacy raw SQL files on BigQuery. ## Changes ### **API-based Implementations** - Migrated `getImportedKeys(...)` to fetch and scan foreign keys from standard table definitions. - Migrated `getCrossReference(...)` to matching parent and foreign table references using client-side definitions. - Utilized the shared parallel table processor utilities (`processTargetTablesConcurrently(...)` and `processSingleTable(...)`) to run dataset scans concurrently. ### **Sorting & Correctness** - Separated sorting behavior according to the JDBC specification: - `getImportedKeys` is sorted by parent table: `PKTABLE_CAT, PKTABLE_SCHEM, PKTABLE_NAME, KEY_SEQ`. Introduced `definePkTableSortComparator` for this. - `getCrossReference` (and future `getExportedKeys`) is sorted by child table: `FKTABLE_CAT, FKTABLE_SCHEM, FKTABLE_NAME, KEY_SEQ`. Uses `defineFkTableSortComparator`. - Introduced a private helper `matchesOrNullWildcard(...)` to simplify and clean up catalog/schema bounds comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/532249777
This PR migrates the
getImportedKeysandgetCrossReferenceJDBC metadata methods inBigQueryDatabaseMetaDatato retrieve constraints natively via the Google Cloud Java Client API instead of running legacy raw SQL files on BigQuery.Changes
API-based Implementations
getImportedKeys(...)to fetch and scan foreign keys from standard table definitions.getCrossReference(...)to matching parent and foreign table references using client-side definitions.processTargetTablesConcurrently(...)andprocessSingleTable(...)) to run dataset scans concurrently.Sorting & Correctness
getImportedKeysis sorted by parent table:PKTABLE_CAT, PKTABLE_SCHEM, PKTABLE_NAME, KEY_SEQ. IntroduceddefinePkTableSortComparatorfor this.getCrossReference(and futuregetExportedKeys) is sorted by child table:FKTABLE_CAT, FKTABLE_SCHEM, FKTABLE_NAME, KEY_SEQ. UsesdefineFkTableSortComparator.matchesOrNullWildcard(...)to simplify and clean up catalog/schema bounds comparisons.