Fix an issue where subcomponent factory method fails when defined with type parameters. - #5260
Merged
Merged
Conversation
…h type parameters. This CL updates `BindingGraph.factoryMethodRequirements()` to explicitly resolve the factory method's parameters against the parent component's concrete type using `asMemberOf(parentType)` to properly handle cases where a component might inherit from a generic interface. For example, ``` @component interface Parent extends SubcomponentProvider<Child, ChildModule> {} interface SubcomponentProvider<C, M> { C createSubcomponent(M module); } ``` Previously, the compiler failed to resolve the parameter `M` to the concrete `ChildModule` type which leads to the following error: ``` java.lang.IllegalArgumentException at plugin.apt.turbine//com.google.common.base.Preconditions.checkArgument(Preconditions.java:136) at plugin.apt.turbine//dagger.internal.codegen.binding.ComponentRequirement.forModule(ComponentRequirement.java:190) at plugin.apt.turbine//dagger.internal.codegen.binding.BindingGraph.lambda$factoryMethodRequirements$0(BindingGraph.java:450) ``` RELNOTES=N/A PiperOrigin-RevId: 972676784
copybara-service
Bot
force-pushed
the
test_965438864
branch
from
August 28, 2026 17:55
22af278 to
4fbc045
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where subcomponent factory method fails when defined with type parameters.
This CL updates
BindingGraph.factoryMethodRequirements()to explicitly resolve the factory method's parameters against the parent component's concrete type usingasMemberOf(parentType)to properly handle cases where a component might inherit from a generic interface.For example,
Previously, the compiler failed to resolve the parameter
Mto the concreteChildModuletype which leads to the following error:RELNOTES=N/A