fix: lazy load Resource Manager client in create flow#5770
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This is fixed in main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_gcp_projects()returning an empty list when the optional Resource Manager dependency is unavailableFixes #5766
To verify
.\.venv\Scripts\python.exe -m pytest tests/unittests/cli/utils/test_gcp_utils.py -q -p no:cacheprovider.\.venv\Scripts\python.exe -m py_compile src\google\adk\cli\utils\gcp_utils.py tests\unittests\cli\utils\test_gcp_utils.pyuv run --extra dev mypy --config-file pyproject.toml src\google\adk\cli\utils\gcp_utils.pyuv run --extra dev pyink --check src\google\adk\cli\utils\gcp_utils.py tests\unittests\cli\utils\test_gcp_utils.pygit diff --checkNotes
uv run --extra test ...is currently blocked on Windows byyarl==1.24.1, which has nowin_amd64wheel or source distribution.