fix: CA cert pool should be cloned not returned as pointer#455
Merged
Conversation
fredbi
changed the title
The basePool function returns the input pool directly without cloning it. According to the documentation in TLSClientOptions, callers must not use the supplied pool after calling TLSClientAuth. However, when the pool is non-nil, this function returns it as-is, which could lead to unintended mutations if the caller continues using it. Consider cloning the pool or updating the implementation to match the documented contract. Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
=========================================
Coverage ? 83.45%
=========================================
Files ? 62
Lines ? 4387
Branches ? 0
=========================================
Hits ? 3661
Misses ? 567
Partials ? 159 ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
ai-findings-autofix/client-tls.go
branch
from
00b5953 to
d1b1ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 2/2 suggestions from code quality AI findings.
Signed-off-by: Frederic BIDON fredbi@yahoo.com