middleware/parameter.go: fix comment describing ParseForm fallback#451
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix comment clarification in parameter.go regarding ParseForm usage
middleware/parameter.go: fix comment describing ParseForm fallback
May 14, 2026
fredbi
approved these changes
May 14, 2026
…-multipart types Agent-Logs-Url: https://github.com/go-openapi/runtime/sessions/19da5630-9b1a-4aec-ac77-ca9c8552d4c3 Co-authored-by: fredbi <14262513+fredbi@users.noreply.github.com>
9aac09b to
6ee37dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
=========================================
Coverage ? 83.45%
=========================================
Files ? 62
Lines ? 4387
Branches ? 0
=========================================
Hits ? 3661
Misses ? 567
Partials ? 159 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment describing the form-parsing helper's Content-Type routing was misleading: it said "otherwise → ParseForm", implying only
application/x-www-form-urlencodedtriggersParseForm. In reality, all non-multipart content types fall through toParseForm— matching the actual logic inform.go.middleware/parameter.go: replaceotherwise → ParseFormwith an explicit statement that all non-multipart types, includingapplication/x-www-form-urlencoded, route toParseFormOriginal prompt