chore(renovate): hold got on the v11 line#2960
Open
afonsojramos wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop Renovate from proposing
gotv12+ bumps.The
gotentry inpnpm-workspace.yamlis apnpmoverride that exists only to force a patched version of a transitive dev-tooling dependency so security scanners stay quiet. It does not ship in the packaged app.A
pnpmoverride forces the version on every consumer, andgotis pulled in by@electron/get(viaelectron-builder) andreact-devtools, both built against the non-ESMgotv11 API.gotis ESM-only from v12 with a changed API, so forcing v12+ onto those consumers risks breaking the Electron build for no benefit:got@11.8.5+already contains the security fix, so there is no security upside to going past v11.This adds a
packageRulesentry constraininggotto<12, which keeps future v11.x patches flowing while suppressing the v12/v13/v14/v15 major PRs (#2952-#2955, now closed).