fix(filters): keep directly-addressed notifications when excluding by author#2959
Open
afonsojramos wants to merge 2 commits into
Open
fix(filters): keep directly-addressed notifications when excluding by author#2959afonsojramos wants to merge 2 commits into
afonsojramos wants to merge 2 commits into
Conversation
|
Member
|
I've been thinking about this FR... GitHub UI doesn't distinguish between author or commenter, since notifications always show the latest state - so I was tempted to close the FR as unplanned... That said, alternatively, we could look to change the filter include/exclude tokens to support I'm not sure I'm a fan of changing the filter based on the notification subject code |
Member
Author
|
@setchy fair... It is also forge specific code that is leaking A LOT tbh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



An
author:exclude filter was hidingreview_requested,assign, andmentionnotifications when a bot (such as coderabbitai) merely left the latest comment, because enrichment setssubject.userto the last commenter. The exclude now skips notifications whose reason means the user was directly asked to act (approval_requested,assign,mention,review_requested,team_mention), while still filtering passive bot comment noise (subscribed/comment). The exemption is scoped to theauthor:qualifier and to excludes only, so include,org:, andrepo:filters are unchanged. Adds regression and unit tests covering the new behaviour.Closes #2914