Skip to content

fix(filters): keep directly-addressed notifications when excluding by author#2959

Open
afonsojramos wants to merge 2 commits into
mainfrom
abuja-v2
Open

fix(filters): keep directly-addressed notifications when excluding by author#2959
afonsojramos wants to merge 2 commits into
mainfrom
abuja-v2

Conversation

@afonsojramos
Copy link
Copy Markdown
Member

An author: exclude filter was hiding review_requested, assign, and mention notifications when a bot (such as coderabbitai) merely left the latest comment, because enrichment sets subject.user to the last commenter. The exclude now skips notifications whose reason means the user was directly asked to act (approval_requested, assign, mention, review_requested, team_mention), while still filtering passive bot comment noise (subscribed/comment). The exemption is scoped to the author: qualifier and to excludes only, so include, org:, and repo: filters are unchanged. Adds regression and unit tests covering the new behaviour.

Closes #2914

@github-actions github-actions Bot added the bug Something isn't working label Jun 3, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

@setchy
Copy link
Copy Markdown
Member

setchy commented Jun 3, 2026

I've been thinking about this FR...

GitHub UI doesn't distinguish between author or commenter, since notifications always show the latest state - so I was tempted to close the FR as unplanned...

That said, alternatively, we could look to change the filter include/exclude tokens to support author: and commenter: prefixes which could search on the two different user attributes.

I'm not sure I'm a fan of changing the filter based on the notification subject code

@afonsojramos
Copy link
Copy Markdown
Member Author

@setchy fair... It is also forge specific code that is leaking A LOT tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

author: exclude filter suppresses review_requested notifications on matching PRs

2 participants