Skip to content

Fix composition pipeline fast-path contract - #19

Closed
nicolehaugen with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-stage2-naming-mismatch
Closed

Fix composition pipeline fast-path contract#19
nicolehaugen with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-stage2-naming-mismatch

Conversation

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown

The composition refresh flow still used the retired stage2Needed contract, incorrectly bypassing LLM pipeline inference. This aligns the runtime on pipelineFastPath while retaining LLM inference as the non-fast fallback.

  • Fast-path contract

    • Rename the deterministic decision helper to computePipelineFastPath.
    • Return pipelineFastPath: true only when inferredPipeline can be synthesized.
  • Refresh dispatch

    • Bypass LLM inference only for a successful deterministic pipeline:
if (fast?.ok && fast.pipelineFastPath) {
    return { kind, fastComposition: true };
}
  • Fall through to LLM inference for novel commands, stack directives, or missing canonical anchors.

  • Terminology and coverage

    • Replace obsolete Stage 1/2 naming with “pipeline fast path” and “LLM inference.”
    • Update tests for deterministic synthesis and LLM fallback behavior.

Copilot AI balanced review requested due to automatic review settings August 26, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Co-authored-by: nicolehaugen <10600161+nicolehaugen@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 26, 2026 20:04
Co-authored-by: nicolehaugen <10600161+nicolehaugen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix stage2 naming mismatch in composition fast-path flow Fix composition pipeline fast-path contract Aug 26, 2026
Copilot AI requested a review from nicolehaugen August 26, 2026 20:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

if (kind === "composition.refresh") {
const fast = await runFastComposition(inst, { reason: "refresh-button" });
if (fast?.ok && !fast.stage2Needed) {
if (fast?.ok && fast.pipelineFastPath) {
Copilot AI review requested due to automatic review settings August 26, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@nicolehaugen

Copy link
Copy Markdown
Contributor

This is being addressed as part of the main PR 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants