Skip to content

feat(http): implement HeaderAllowedFeatureFlags for X-MCP-Features header validation #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 3 commits into from
Apr 15, 2026
+103 −1
Merged

feat(http): implement HeaderAllowedFeatureFlags for X-MCP-Features header validation #2332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db93029
feat(http): implement HeaderAllowedFeatureFlags for X-MCP-Features he…
mattdholloway Apr 15, 2026
1bb1765
Apply suggestion from @Copilot
mattdholloway Apr 15, 2026
e213579
feat(http): update knownFeatureFlags to use HeaderAllowedFeatureFlags…
mattdholloway Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/github/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,17 @@ var (
// When active, consolidated tools are replaced by single-purpose granular tools.
FeatureFlagIssuesGranular = "issues_granular"
FeatureFlagPullRequestsGranular = "pull_requests_granular"
)

// HeaderAllowedFeatureFlags are the feature flags that clients may enable via the
// X-MCP-Features header. Only these flags are accepted from headers; unknown flags
// are silently ignored.
var HeaderAllowedFeatureFlags = []string{
FeatureFlagIssuesGranular,
FeatureFlagPullRequestsGranular,
}

Comment thread
mattdholloway marked this conversation as resolved.
Outdated
var (
// Remote-only toolsets - these are only available in the remote MCP server
// but are documented here for consistency and to enable automated documentation.
ToolsetMetadataCopilotSpaces = inventory.ToolsetMetadata{
Expand Down
2 changes: 1 addition & 1 deletion pkg/http/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (

// knownFeatureFlags are the feature flags that can be enabled via X-MCP-Features header.
// Only these flags are accepted from headers.
var knownFeatureFlags = []string{}
var knownFeatureFlags = github.HeaderAllowedFeatureFlags
Comment thread
mattdholloway marked this conversation as resolved.
Outdated

type ServerConfig struct {
// Version of the server
Expand Down
Loading