Skip to content

JS: Support for Request and NextRequest#19184

Merged
Napalys merged 12 commits intogithub:mainfrom
Napalys:js/request_handlers
Apr 14, 2025
Merged

JS: Support for Request and NextRequest#19184
Napalys merged 12 commits intogithub:mainfrom
Napalys:js/request_handlers

Conversation

@Napalys
Copy link
Copy Markdown
Contributor

@Napalys Napalys commented Apr 1, 2025

The following pull request adds main two changes:

  • Data passed to the NextResponse constructor is now treated as a sink for js/reflected-xss.
  • Data received from NextRequest and Request is now treated as a remote user input source.

@github-actions github-actions Bot added the JS label Apr 1, 2025
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Fixed
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Fixed
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Fixed
@Napalys Napalys force-pushed the js/request_handlers branch from ac5e07d to a1dee15 Compare April 1, 2025 13:01
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Fixed
@Napalys Napalys force-pushed the js/request_handlers branch 3 times, most recently from dda274c to ca5a834 Compare April 1, 2025 17:40
@Napalys Napalys force-pushed the js/request_handlers branch from 736e6df to 2c4b352 Compare April 11, 2025 07:42
@Napalys Napalys marked this pull request as ready for review April 11, 2025 07:57
@Napalys Napalys requested a review from a team as a code owner April 11, 2025 07:57
Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! 👍

Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Outdated
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Outdated
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Outdated
Comment thread javascript/ql/lib/semmle/javascript/frameworks/Next.qll Outdated
@Napalys Napalys requested a review from asgerf April 11, 2025 09:28
Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Napalys Napalys merged commit 8631371 into github:main Apr 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants