Skip to content

JS: support hana db client #19118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Napalys merged 14 commits into from
Mar 31, 2025
Merged

JS: support hana db client #19118

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
032cfc1
Added test cases for `hana` clients.
Napalys Mar 25, 2025
9229962
Add sink model for SQL injection detection in `exec` clients.
Napalys Mar 25, 2025
d28af95
Added sink models for `hana`'s client `prepare` function.
Napalys Mar 25, 2025
e595def
Modeled `execute` as potential `hana`'s sink.
Napalys Mar 25, 2025
0285cb6
Added `@sap/hdbext.loadProccedure` as sql sink.
Napalys Mar 25, 2025
7cc0634
Added `createProcStatement` as potential sql sink.
Napalys Mar 25, 2025
4cdc40d
Added SQL injection detection for `exec` method embeded Express clien…
Napalys Mar 25, 2025
62ab7f5
Added change note.
Napalys Mar 26, 2025
e69929e
Update javascript/ql/lib/change-notes/2025-03-26-hana-db-client.md
Napalys Mar 27, 2025
f7264d8
Merge branch 'main' into js/hana_db_client
Napalys Mar 28, 2025
f3af23e
Refactored hana's DB client to use `GuardedRouteHandler`, improving p…
Napalys Mar 28, 2025
d0e2aa8
Added sources from `hana` db as `MaD`.
Napalys Mar 28, 2025
45c8ec9
Added test cases for `hana` db additional sources.
Napalys Mar 28, 2025
32d6ac8
Add test case to ensure `exec` calls without middleware injection int…
Napalys Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions javascript/ql/lib/ext/hana-db-client.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ extensions:
extensible: sinkModel
data:
- ["@sap/hana-client", "Member[createConnection].ReturnValue.Member[exec,prepare].Argument[0]", "sql-injection"]
- ["hdb", "Member[createClient].ReturnValue.Member[exec,prepare,execute].Argument[0]", "sql-injection"]
- ["hdb.Client", "Member[exec,prepare,execute].Argument[0]", "sql-injection"]
- ["@sap/hdbext", "Member[loadProcedure].Argument[2]", "sql-injection"]
- ["@sap/hana-client/extension/Stream", "Member[createProcStatement].Argument[1]", "sql-injection"]
- ["express", "ReturnValue.Member[get].Argument[1].Parameter[0].Member[db].Member[exec].Argument[0]", "sql-injection"]

- addsTo:
pack: codeql/javascript-all
extensible: typeModel
data:
- ["hdb.Client", "hdb", "Member[createClient].ReturnValue"]
- ["hdb.Client", "@sap/hdbext", "Member[middleware].ReturnValue.GuardedRouteHandler.Parameter[0].Member[db]"]
Copy link
Copy Markdown
Contributor

@erik-krogh erik-krogh Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test that reg.db.exec(..) isn't a sink when there is no call to hdb.createClient().

Copy link
Copy Markdown
Contributor Author

@Napalys Napalys Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 32d6ac8