Skip to content

Java: fix comma splice in alert message#19092

Merged
nickrolfe merged 1 commit intomainfrom
nickrolfe/comma-splice
Mar 21, 2025
Merged

Java: fix comma splice in alert message#19092
nickrolfe merged 1 commit intomainfrom
nickrolfe/comma-splice

Conversation

@nickrolfe
Copy link
Copy Markdown
Contributor

From https://en.wikipedia.org/wiki/Comma_splice:

It is usually considered an error in English writing style.

@github-actions github-actions Bot added the Java label Mar 21, 2025
Copy link
Copy Markdown
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this doesn't cause closing/reopening of alerts

@nickrolfe nickrolfe marked this pull request as ready for review March 21, 2025 14:35
@nickrolfe nickrolfe requested a review from a team as a code owner March 21, 2025 14:35
@nickrolfe
Copy link
Copy Markdown
Contributor Author

I will check before merging.

@nickrolfe
Copy link
Copy Markdown
Contributor Author

I've received reassurance that changing the query text won't cause any such issues.

@nickrolfe nickrolfe merged commit 631ccdf into main Mar 21, 2025
14 of 15 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/comma-splice branch March 21, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants