Skip to content

Fix releases/v3 branch - #4060

Merged
mbg merged 5 commits into
releases/v3from
fix/revert-rebuild
Jul 31, 2026
Merged

Fix releases/v3 branch#4060
mbg merged 5 commits into
releases/v3from
fix/revert-rebuild

Conversation

@mbg

@mbg mbg commented Jul 30, 2026

Copy link
Copy Markdown
Member

On every recent CodeQL Action release, we have run into a merge conflict on the PR that merges back changes to the releases/v3 branch. That is because part of the mergeback PR process is to revert the most recent commit titled "Rebuild". Each time, the conflict has been resolved by rebuilding the JS and committing the resolution as "Rebuild", causing it to be discarded again the next time.

This PR mirrors the mergeback process, with the exception of a separate commit to resolve the merge conflict, by:

  • Reverting the "Update version" and "Rebuild" commits added during the last actual mergeback process.
  • Resolving the merge conflict.
  • Re-applying the "Update version" commit
  • Rebuilding

During the next actual mergeback process, reverting the last two commits should then not revert the merge conflict resolution.

@github-actions github-actions Bot added the size/XS Should be very easy to review label Jul 30, 2026
@mbg
mbg force-pushed the fix/revert-rebuild branch from 70b0fd6 to 85722ca Compare July 30, 2026 17:08
@mbg
mbg marked this pull request as ready for review July 30, 2026 19:59
Copilot AI review requested due to automatic review settings July 30, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@oscarsj oscarsj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 thanks, this was a confusing step in the process

@mbg
mbg merged commit fa3b8d4 into releases/v3 Jul 31, 2026
222 checks passed
@mbg
mbg deleted the fix/revert-rebuild branch July 31, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants