Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test to ensure a non-bare repository whose worktree directory name ends with .git can be added as a GitButler project and reopened reliably, and updates gix/gix-testtools to a revision that contains the upstream fix.
Changes:
- Add a new
gitbutler-projectintegration test covering a worktree directory namednon-bare.gitand verifyinggit_dir, serializedpath, andopen_isolated_repo()behavior. - Bump
gixandgix-testtoolsworkspace dependencies (and the[patch.crates-io]override) to the new git revision containing the fix.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/gitbutler-project/tests/project/main.rs | Adds an integration test to validate adding/loading a repo whose worktree directory ends with .git. |
| Cargo.toml | Updates gix/gix-testtools versions and pins gix via [patch.crates-io] to the same upstream revision. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09f5fbe769
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add a test here, while the fix comes from `gix`. This also includes a full `cargo update` as otherwise dependencies wouldn't resolve.
Add a test here, while the fix comes from
gix.Tasks
Notes for the reviewer
This also includes a full
cargo updateas otherwisegix-tracewouldn't resolve. I cleared GitHub caches preemptively to be sure the runners don't run out of space.As long as git-meta/git-meta#102 isn't merge and the revision of
git-meta-libis updated here, there will bygixduplicates in the dependency tree.This can be a follow-up, or be done as part of the PR here depending on timing.