(do not review) test to see if CI detects mtime issues#14367
Open
jonathantanmy2 wants to merge 1 commit into
Open
(do not review) test to see if CI detects mtime issues#14367jonathantanmy2 wants to merge 1 commit into
jonathantanmy2 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test in the but CLI integration test suite intended to detect unintended file mtime changes caused by but commit, likely to validate CI behavior around mtime handling.
Changes:
- Add a new test that attempts to assert
but commitdoes not modify a working-tree file’s modification time.
Comment on lines
+1634
to
+1643
| let old_time = std::fs::metadata(env.projects_root().join("A"))?.modified()?; | ||
|
|
||
| env.file("A", "new content"); | ||
| env.but("commit -m test").assert().success(); | ||
|
|
||
| let new_time = std::fs::metadata(env.projects_root().join("A"))?.modified()?; | ||
| assert_eq!( | ||
| new_time, old_time, | ||
| "time should be the same, because file should not have been modified" | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test to see if CI detects mtime issues