Repository navigation
Cache Conan 2 recipe and package archives - #431
Open
pinguinfuss wants to merge 3 commits into
Open
pinguinfuss wants to merge 3 commits into
pinguinfuss wants to merge 3 commits into
Conversation
…ons/{rrev}/files/{file} and .../packages/{id}/revisions/{prev}/files/{file}, but the handler only cached the invalid /v1/files and /v2/files paths, so archives were never stored. This adds the real routes and drops the old ones; manifests and conaninfo.txt stay in the metadata cache.
…txz, conan_package.tzst and so on), so cache those too.
…b@1.3.1, with the revisions and any user/channel in the filename. The old name/version@user/channel with one version per revision never matched a denylist entry or what scanners look up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conan 2 fetches recipe and package files from
/v2/conans/{ref}/revisions/{rrev}/files/{file}and.../packages/{id}/revisions/{prev}/files/{file}. The handler only cached/v1/filesand/v2/files, which no client uses. Soconan installnever stored an archive: no offline copies, and scanning, max_size and retention never saw them.This adds the real routes and drops the old ones. v1 hands out signed URLs on the upstream host, so those downloads never came through the proxy anyway. Manifests and conaninfo.txt stay in the metadata cache. The xz and zstd archives Conan 2.25 can upload (
.txz,.tzst) are cached too.Archives are now stored as
pkg:conan/zlib@1.3.1, with the revisions and any user/channel in the filename, so a denylist entry likepkg:conan/zlib@1.3.1actually blocks them. Before, every revision was its own version of a package calledzlib/1.3.1@_/_.With
cache_metadataon, archives cached before this change are fetched again on first use. Their old_metadata/conan/entries are no longer read and can be deleted.Tests cover the real paths, caching, separate user/channel files and the denylist.