chore(seer-activity): Add SLOs for integrations, refactor email to raise properly#118272
Merged
leeandher merged 3 commits intoJun 23, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3103452. Configure here.
Christinarlong
approved these changes
Jun 23, 2026
leeandher
deleted the
leanderrodrigues/iswf-2732-add-logging-andor-metrics
branch
sehr-m
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ise properly (#118272) Records SLOs for integrations, for email we can use the notification platform metrics. In theory we could use those for both, but the specs will make sure the metrics land alongside metrics they're related to. Note: The notification platform doesn't raise API errors, so those won't be caught here. In practice we're actually just making sure that the payload assembly before the notification is scheduled is working as expected. These routes have calls(e.g. `require_config(...)`, `require_integration_id(...)` that will raise `ValueErrors`, and cause the SLO to fail -- this is what we're catching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records SLOs for integrations, for email we can use the notification platform metrics. In theory we could use those for both, but the specs will make sure the metrics land alongside metrics they're related to.
Note: The notification platform doesn't raise API errors, so those won't be caught here. In practice we're actually just making sure that the payload assembly before the notification is scheduled is working as expected. These routes have calls(e.g.
require_config(...),require_integration_id(...)that will raiseValueErrors, and cause the SLO to fail -- this is what we're catching.